Classes for skimming recon events and a possible V0 skim setup#1086
Merged
bloodyyugo merged 4 commits intomasterfrom Mar 28, 2025
Merged
Classes for skimming recon events and a possible V0 skim setup#1086bloodyyugo merged 4 commits intomasterfrom
bloodyyugo merged 4 commits intomasterfrom
Conversation
mgignac
approved these changes
Mar 5, 2025
Collaborator
mgignac
left a comment
mgignac
left a comment
There was a problem hiding this comment.
Code looks fine to me, thanks! Of course this will need to be tested. One thing we may need to confirm is whether the cuts are valid across all runs, but that can be confirmed later.
baltzell
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes issue #1085